-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add przemienniki.net query source #703
Conversation
@szporwolik this is a suuuuper fast implementation this morning while eating breakfast. Please test thoroughly ;D |
Also, if you have better text to put into the "info" blob for this, that would be good. The info on each of these sources is suppose to be a short description, so maybe something like "A european repeater database" or something? |
fc56fbf
to
e690a4f
Compare
Oops, forgot to commit the new file. I blame breakfast ;) |
@kk7ds thank your for this quick implementation! Things that I would suggest to change, prior merging (the minimum functionality):
|
Fixed.
Hmm, yeah, DV returns nothing for me in any country (that I tried). I just added this because it was in the other implementation. Perhaps these are all gone, or no longer supported in the database?
Yep, I was passing 'Latitude' instead of 'latitude' (et al) and the API seems to be case-sensitive. I think it's fixed now.
This is in the tooltip. I can change this at some point, but it will invalidate all the translation strings for the other dialogs that use the same,.
Sounds fine to me.
Done. Will push an update in a sec. I'm going to be unavailable for the rest of the week, so if you can again test real quick we should be able to get this merged before I go. Thanks! |
Quickly tested. Functionally I think this is a perfect start! If possible it would be good the have the query repeaters sorted by name (now it seems a bit random, when coordinates are not given). This is minor feature request. Great thank you! |
Okay, cool, thanks for your help. I will merge this soon. The sort order is whatever is returned from the database server. You think sort by name (not frequency) is best? |
This update sorts by name if either lat and/or lon is not provided. I think the server sorts by distance when those are provided, so this gives you either server sort order by distance, or name if not. Easy to change to frequency if you think that's better, otherwise this should be good. |
This is very rough and lightly tested so far. Fixes #10700
This is very rough and lightly tested so far.
Fixes #10700